HidePrefix and PrefixOnly are still effective #3868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-Solyanik
force-pushed
the
flags
branch
from
04688ee to
7158724
Compare
Tanya-Solyanik
force-pushed
the
flags
branch
from
589ef3b to
a20e47c
Compare
|
@mairaw, could you please take a look at this change? I based my changes on the Win32 docs because these flags are used as parameters to the P/Invoked Win32 API. I had also verified their functionality in a test app for sanity. |
mairaw
requested changes
Feb 12, 2020
There was a problem hiding this comment.
Looks good @Tanya-Solyanik. Left a few comments for you to consider.
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
Co-Authored-By: Maira Wenzel <[email protected]>
|
Thank you, @mairaw, I accepted all suggestions! |
mairaw
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Thank you @Tanya-Solyanik. I've also noticed a missing white space. I'll merge as soon as builds are green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2903